buffer/decoration.ts (2)

38-43: Clarify JSDoc: negative values allowed

Call out that negative priorities are allowed (per Vim’s behavior) to set expectations for consumers.

Apply this diff to the JSDoc:

-  /**
-   * Priority for the decoration (higher numbers are displayed on top)
-   * Defaults to 0 if not specified
-   */
+  /**
+   * Priority for the decoration (higher numbers are displayed on top).
+   * Negative values are allowed. Defaults to 0 when omitted.
+   */

---

260-276: Make Vim listing faster and more robust (fallback + cache + safe highlight parse)

• Avoid 1 RPC per prop by caching type->priority.
• Fallback to 0 when prop_type_get() returns no priority.
• Parse highlight without relying on .split(':').pop() so it won’t break if a highlight ever contains a colon.

Apply this diff:

-  return Promise.all(
-    props
-      .filter((prop) => prop.type.startsWith(`${prefix}:`))
-      .map(async (prop) => {
-        const propType = await vimFn.prop_type_get(denops, prop.type) as {
-          priority: number;
-        };
-        return ({
-          line: prop.lnum,
-          column: prop.col,
-          length: prop.length,
-          highlight: prop.type.split(":").pop() as string,
-          priority: propType.priority,
-        });
-      }),
-  );
+  const filtered = props.filter((prop) => prop.type.startsWith(`${prefix}:`));
+  const typePriorityCache = new Map<string, number>();
+  return Promise.all(filtered.map(async (prop) => {
+    let prio = typePriorityCache.get(prop.type);
+    if (prio == null) {
+      const t = await vimFn.prop_type_get(denops, prop.type) as { priority?: number };
+      prio = t.priority ?? DEFAULT_DECORATION_PRIORITY;
+      typePriorityCache.set(prop.type, prio);
+    }
+    const head = `${prefix}:${prio}:`;
+    const highlight = prop.type.startsWith(head)
+      ? prop.type.slice(head.length)
+      : prop.type; // safe fallback
+    return {
+      line: prop.lnum,
+      column: prop.col,
+      length: prop.length,
+      highlight,
+      priority: prio,
+    };
+  }));

buffer/decoration_test.ts (1)

57-66: Avoid asserting internal Vim prop type naming

Asserting the exact type string (including embedded priority) tightly couples tests to an internal naming scheme. Prefer verifying behavior via listDecorations or by checking the priority through prop_type_get() for the relevant type(s).

Example alternatives:

• Use listDecorations to assert highlight range and omit type internals.
• Or, derive the prop type name, call prop_type_get(), and assert priority: 0.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro